Skip to content

/ PrestaShop

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Product Details" tab must be hidden if there is no data to display #18916

Open
Klemart3D opened this issue Apr 30, 2020 · 6 comments · May be fixed by #19165
Open

"Product Details" tab must be hidden if there is no data to display #18916

Klemart3D opened this issue Apr 30, 2020 · 6 comments · May be fixed by #19165
Labels
1.7.6.5 FO Improvement PM ✔️ PR available Products To Do

Comments

@Klemart3D
Copy link
Contributor

@Klemart3D Klemart3D commented Apr 30, 2020

Describe the bug

On product page in FO, "Product Details" tab is visible and empty even if there is no data to display.

Expected behavior

No "Product Details" tab if there is no data to display. And no white block if there is no Description too.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Remove brand, reference and features in a product (e.g. "Mug Today is a good day" in demo).
  2. Disable display quantity on product page option in parameters
  3. On product page, "Product Details" is still visible, but no data:

product-detail-tab-not-hidden

Additional information

  • PrestaShop version: 1.7.6.5
  • PHP version: 7.1
@prestashop-issue-bot
Copy link

@prestashop-issue-bot prestashop-issue-bot bot commented Apr 30, 2020

Thanks for opening this issue! We will help you to keep its state consistent
@florine2623
Copy link

@florine2623 florine2623 commented Apr 30, 2020

Hi @Klemart3D ,
Thanks for the recommandation, I'm facing the same behaviour.
I will let our product team know about it !
@florine2623
Copy link

@florine2623 florine2623 commented Apr 30, 2020

Hi @PrestaShop/prestashop-product-team ,

What do you think of this improvement ?

Thanks !
@marionf
Copy link
Contributor

@marionf marionf commented Apr 30, 2020

Nice idea @Klemart3D feel free to sumbit a PR if you know how to do that
@Klemart3D Klemart3D changed the title "Product Details" tab must me hidden if there is no data to display "Product Details" tab must be hidden if there is no data to display Apr 30, 2020
@gabrielobleite gabrielobleite linked a pull request that will close this issue May 16, 2020
Open
@gabrielobleite
Copy link

@gabrielobleite gabrielobleite commented May 16, 2020

Hi, have created a PR to solve that issue:
#19165

Hope that is good.
@TechDigital01

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.7.6.5 FO Improvement PM ✔️ PR available Products To Do
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Hide Product Details when no info available to show in tab
7 participants
@Klemart3D @marionf @florine2623 @LouiseBonnard @gabrielobleite @TechDigital01 and others
You can’t perform that action at this time.