Skip to content

/ chat

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the function to delete / edit a message with a mini archive of this message. #247

Open
VictorV96 opened this issue Jun 20, 2019 · 4 comments
Open

Adding the function to delete / edit a message with a mini archive of this message. #247

VictorV96 opened this issue Jun 20, 2019 · 4 comments
Labels
feature request

Comments

@VictorV96
Copy link

@VictorV96 VictorV96 commented Jun 20, 2019 •
edited

Subject of the issue

Adding the function to delete / edit a message with a mini archive of this message.

Is this a bug report of a feature request?

  • Bug report
  • [+] Feature request

Your environment

Server-side

  • [+] api.tinode.co
  • [+] Your own setup:
    Linux
    Клиент: TinodeWeb/0.16.0-rc1 (tinodejs/0.16.0-rc1)
    Сервер: 0.16 rethinkdb:v0.16.0-rc1; (api.tinode.co)

Client-side

  • [+] TinodeWeb/tinodejs: javascript client
    • Browser make and version.
  • [+] Tindroid: Android app
    • Android API level (e.g. 25).
    • Emulator or hardware, if hardware describe it.
  • tn-cli
    • Python version
  • Chatbot
    • Python version
  • Version of the client, e.g. 0.15.1

Steps to reproduce

Deleting a message

Expected behaviour

Delete / edit the message from the sender (the message frame remains, only the text changes to "Message deleted" / "Edited message"). Deleted / edited message by the recipient "Message deleted" / "Edited message".

But in both cases it is possible to see the history of editing | delete.

Actual behaviour

Deletion on the client side.
maxresdefault
maxresdefault (1)
5bd7c8f4708afe28f8
@VictorV96
Copy link
Author

@VictorV96 VictorV96 commented Jun 20, 2019

Mini archive can be implemented by changing the message column from the text format in json. If a string arrives, then this is a normal message. If json arrives then this is edited or deleted message.
@or-else
Copy link
Contributor

@or-else or-else commented Jun 20, 2019 •
edited

  1. Deleting the message with an indicator.

The messages can be deleted already. What's missing is the indicator of the message having been deleted. Such an indicator is a purely client-side feature. The messages are numbered sequentially (the seq value). A gap in seq values means one or more messages ware deleted. Maybe you can help adding this feature for one of the clients?

  1. Editing the message.

It's also a client-only feature.
See discussion here: https://groups.google.com/d/msg/tinode/XsqcEF-WqkI/1bO-LiP9AQAJ
@VictorV96
Copy link
Author

@VictorV96 VictorV96 commented Jun 24, 2019 •
edited

Смотрите обсуждение здесь: https://groups.google.com/d/msg/tinode/XsqcEF-WqkI/1bO-LiP9AQAJ
У меня нет к нему доступа, или темы не существует.

See the discussion here: https://groups.google.com/d/msg/tinode/XsqcEF-WqkI/1bO-LiP9AQAJ
I do not have access, or the topic does not exist.
@or-else
Copy link
Contributor

@or-else or-else commented Jun 25, 2019

I found another option which was not set to be open to everybody. Please check the link again. It should work now. I can see the group even in incognito window without any login or cookies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@or-else @VictorV96
You can’t perform that action at this time.