Skip to content

[tests] Don't revoke VERCEL_TOKEN after tests run #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2020
Merged

[tests] Don't revoke VERCEL_TOKEN after tests run #4643

merged 2 commits into from
Jun 12, 2020

Conversation

MaxLeiter
Copy link
Member

@MaxLeiter MaxLeiter commented Jun 12, 2020 •
edited
Loading

VERCEL_TOKEN will no longer be invalidated during tests

Story: https://app.clubhouse.io/vercel/story/2281

@MaxLeiter MaxLeiter requested a review from TooTallNate as a code owner June 12, 2020 20:18
@TooTallNate TooTallNate requested a review from styfle June 12, 2020 20:33
TooTallNate
TooTallNate reviewed Jun 12, 2020
View reviewed changes
@TooTallNate TooTallNate changed the title Don't revoke VERCEL_TOKEN during tests [tests] Don't revoke VERCEL_TOKEN after tests run Jun 12, 2020
styfle
styfle approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 56671d7 into master Jun 12, 2020
@kodiakhq kodiakhq bot deleted the maxleiter/dontInvalidateTokenInTests branch June 12, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
area: cli area: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxLeiter @TooTallNate @styfle