Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include soft keywords in keyword.py #20877

Merged
merged 1 commit into from Jun 15, 2020
Merged

Include soft keywords in keyword.py #20877

merged 1 commit into from Jun 15, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 15, 2020

No description provided.

@pablogsal pablogsal requested a review from gvanrossum Jun 15, 2020
@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jun 15, 2020

Given that soft keywords are still unused I have not included a news file: Tell me if you would prefer to include one.

gvanrossum
gvanrossum approved these changes Jun 15, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks! I think no news is needed, this is essentially an internal tool.

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jun 15, 2020

Since soft keywords are supported in 3.9 (even though there are none), should we backport the API there???

@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jun 15, 2020

Since soft keywords are supported in 3.9 (even though there are none), should we backport the API there???

I think so, to make future backports easier more than anything.

@pablogsal pablogsal merged commit 78319e3 into python:master Jun 15, 2020
9 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 15, 2020

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the soft_keywords branch Jun 15, 2020
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 15, 2020

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 78319e373d57cd4da67660f888aa7092efbd6f24 3.9

pablogsal added a commit to pablogsal/cpython that referenced this issue Jun 15, 2020
[3.9] Include soft keywords in keyword.py (pythonGH-20877).
7c61411 
(cherry picked from commit 78319e3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 15, 2020

GH-20880 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this issue Jun 15, 2020
[3.9] Include soft keywords in keyword.py (pythonGH-20877).
fef1a8c 
(cherry picked from commit 78319e3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal pushed a commit that referenced this issue Jun 15, 2020
[3.9] Include soft keywords in keyword.py (GH-20877). (GH-20880)
145fa86 
(cherry picked from commit 78319e3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@hauntsaninja hauntsaninja mentioned this pull request Jun 26, 2020
Merged
@srittau
Copy link
Contributor

@srittau srittau commented Jun 26, 2020

Since the keyword module is documented (https://docs.python.org/3.10/library/keyword.html), I believe this should be added to the docs as well.

@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jun 26, 2020

Since the keyword module is documented (https://docs.python.org/3.10/library/keyword.html), I believe this should be added to the docs as well.

Good catch, I will open a PR soon

@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jun 27, 2020

Opened #21185

J-Arun-Mani pushed a commit to J-Arun-Mani/cpython that referenced this issue Jul 21, 2020
@J-Arun-Mani
Include soft keywords in keyword.py (pythonGH-20877)
d61b1bd
chrisburr added a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@chrisburr
Include soft keywords in keyword.py (pythonGH-20877)
5363ba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees

@pablogsal pablogsal

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@pablogsal @gvanrossum @miss-islington @bedevere-bot @srittau @the-knights-who-say-ni