Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40884: Added defaults parameter for logging.Formatter #20668

Merged
merged 20 commits into from Jun 18, 2020
Merged

bpo-40884: Added defaults parameter for logging.Formatter #20668

merged 20 commits into from Jun 18, 2020

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Jun 5, 2020 •
edited by miss-islington

Docs and tests are underway.

https://bugs.python.org/issue40884

Automerge-Triggered-By: @vsajip

@bharel bharel requested a review from vsajip as a code owner Jun 5, 2020
@bharel
Copy link
Contributor Author

bharel commented Jun 6, 2020

Added docs and tests, all should pass now.
ATM the feature is not implemented for ConfigFile or basicConfig.
Would you wish for me to implement it on both cases?
If so, how shall I name the parameter on basicConfig? (defaults will be a little weird in there)

@vsajip vsajip added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
@bedevere-bot
Copy link

bedevere-bot commented Jun 17, 2020

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 4ba90e4 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
@vsajip vsajip added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jun 18, 2020
vsajip
vsajip approved these changes Jun 18, 2020
View changes
@miss-islington miss-islington merged commit 8f192d1 into python:master Jun 18, 2020
64 checks passed
@vsajip
Copy link
Member

vsajip commented Jun 18, 2020

Would you wish for me to implement it on both cases?

No need.

@csabella
Copy link
Contributor

csabella commented Jun 18, 2020

Nice!

@bharel bharel deleted the default-formatter-values branch Jun 18, 2020
@bharel bharel mentioned this pull request Jun 18, 2020
Closed
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@bharel @arun-mani-j
bpo-40884: Added defaults parameter for logging.Formatter (pythonGH-2…
3f68721 
…0668)

Docs and tests are underway.

Automerge-Triggered-By: @vsajip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip

@PointDreck PointDreck

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bharel @bedevere-bot @vsajip @csabella @PointDreck @the-knights-who-say-ni @miss-islington