Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky `test_aio` CircleCI job due to size check #37699

Open
AndrewKushnir opened this issue Jun 24, 2020 · 5 comments
Open

Flaky `test_aio` CircleCI job due to size check #37699

AndrewKushnir opened this issue Jun 24, 2020 · 5 comments

Comments

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Jun 24, 2020

The test_aio CircleCI job sometimes fails false-positively with the payload size error (over 20kb diff):

FAIL: Commit c95802f uncompressed main-es2015 exceeded expected size by 500 bytes or >1% (expected: 453213, actual: 476811).

Example of the most recent failure in master can be found here. In that particular case, it was a docs-only commit.

Restarting the CircleCI job usually fixes the problem.

cc @gkalpak

@ngbot ngbot bot modified the milestone: needsTriage Jun 24, 2020
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 24, 2020
…flakes

As reported in angular#37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 24, 2020
…flakes

As reported in angular#37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 24, 2020
…flakes

As reported in angular#37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 24, 2020
…flakes

As reported in angular#37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.
gkalpak added a commit to gkalpak/angular that referenced this issue Jun 24, 2020
…flakes

As reported in angular#37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.
@gkalpak
Copy link
Member

@gkalpak gkalpak commented Jun 24, 2020

FYI, I created #37703 to capture more info to help debug this (the next time it happens).

@IgorMinar
Copy link
Member

@IgorMinar IgorMinar commented Jun 25, 2020

another instance: #37686 (comment)

AndrewKushnir added a commit that referenced this issue Jun 26, 2020
…flakes (#37703)

As reported in #37699, the size of the main angular.io bundle sometimes
ends up bigger than expected on CI. This usually goes away after
rerunning the job a couple of times.

It is unclear what is causing this. In order to help debug the issue,
this commit stores the JS files that are checked as part of the aio
payload-size check as CI artifacts, where they can be retrieved from and
inspected.

PR Close #37703
@IgorMinar
Copy link
Member

@IgorMinar IgorMinar commented Jun 27, 2020

two jobs within the same workflow affected by the problem:

And as a bonus - within the same workflow we had the following failures that I cannot reproduce locally:

@AndrewKushnir
Copy link
Contributor Author

@AndrewKushnir AndrewKushnir commented Jun 27, 2020

And as a bonus - within the same workflow we had the following failures that I cannot reproduce locally:

@IgorMinar FYI these two additional issues were resolved in 98c047b (in master) and 78460c1 (in patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.