C++: Clean up BufferWrite.qll#3786
Merged
MathiasVP merged 10 commits intogithub:masterfrom Jul 1, 2020
Merged
Conversation
…them so that information isn't duplicated.
MathiasVP
reviewed
Jun 24, 2020
Contributor
|
Other than the failing ql{doc, format} checks, I think this LGTM! The new test result also looks right to me. |
Contributor
Author
|
Fixed formatting and fixed the new false positive in |
geoffw0
force-pushed
the
bufferwritecleanup
branch
from
5c7d49d to
89bea60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the QLDoc for BufferWrite.qll, I noticed some places where it could depend more on models (reducing redundancy), and where models can be improved using cases from BufferWrite.qll.