Data flow: Further pruning based on read column of nodeCand2() predicate#3780
Closed
hvitved wants to merge 3 commits intogithub:mainfrom
Closed
Data flow: Further pruning based on read column of nodeCand2() predicate#3780hvitved wants to merge 3 commits intogithub:mainfrom
read column of nodeCand2() predicate#3780hvitved wants to merge 3 commits intogithub:mainfrom
Conversation
hvitved
force-pushed
the
dataflow/node-cand2-pruning
branch
from
591c232 to
13cb63c
Compare
Contributor
Author
|
Rebased to resolve merge conflict, and updated difference job links in the PR description. |
Contributor
|
No objections from me. The 7% time increase on torvalds/linux C/C++ seems to be just noise: the two queries with the biggest increase don't use data flow. |
hvitved
force-pushed
the
dataflow/node-cand2-pruning
branch
from
13cb63c to
1c0e23f
Compare
Contributor
Author
|
Rebased again. I have updated the PR description with new tuple counts and links to new Differences jobs. |
hvitved
force-pushed
the
dataflow/node-cand2-pruning
branch
from
1c0e23f to
000fa01
Compare
hvitved
force-pushed
the
dataflow/node-cand2-pruning
branch
from
000fa01 to
7714953
Compare
hvitved
force-pushed
the
dataflow/node-cand2-pruning
branch
from
7714953 to
5ca2f73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing out on additional pruning in
flowCandFwd(), because we ignored thereadcolumn ofnodeCand2().C# tuple counts
Ran this on
mono:Java tuple counts
Ran this on JDK:
Differences jobs: