Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop min certbot coverage #7972
Merged
Conversation
|
and ... having a better coverage on Windows than on Linux currently. I buy it! ;) |
|
Haha nice work on getting Windows test coverage higher than on Linux/macOS. I'm somewhat tempted to modify |
|
Thanks for the review. |
9154e79
into
master
7 checks passed
7 checks passed
limited-test-suite (test windows-integration-certbot)
test windows-integration-certbot succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bmw commentedMay 4, 2020
tox -e coverfails for me on macOS. This is due to the differences in the code that is run when on Linux vs. other platforms incertbot.utiland its tests. Diffing my local coverage with Travis, the only difference in lines missing test coverage is:I think tests on
mastershould not be failing locally for people.While there would be other ways to fix this by adding
# pragma: no coverlines or writing mocked out tests for other platforms, I personally just think dropping the minimum coverage one percentage point is fine at least for now.