Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop min certbot coverage #7972

Merged
merged 1 commit into from May 5, 2020
Merged

Drop min certbot coverage #7972

merged 1 commit into from May 5, 2020

Conversation

@bmw
Copy link
Member

bmw commented May 4, 2020

tox -e cover fails for me on macOS. This is due to the differences in the code that is run when on Linux vs. other platforms in certbot.util and its tests. Diffing my local coverage with Travis, the only difference in lines missing test coverage is:

$ diff travis.txt local.txt
< certbot/certbot/util.py                                        238     24    90%   132-134, 210, 275-281, 318, 330-340, 347, 381-382
> certbot/certbot/util.py                                        239     34    86%   30, 132-134, 210, 275-281, 301, 305, 316-318, 330-340, 347, 367-373, 381-382
< certbot/tests/util_test.py                                     392      0   100%
> certbot/tests/util_test.py                                     375     26    93%   483-487, 492-502, 507-514, 548-550, 555-557

I think tests on master should not be failing locally for people.

While there would be other ways to fix this by adding # pragma: no cover lines or writing mocked out tests for other platforms, I personally just think dropping the minimum coverage one percentage point is fine at least for now.

Copy link
Contributor

adferrand left a comment

and ... having a better coverage on Windows than on Linux currently. I buy it! ;)

@bmw bmw mentioned this pull request May 5, 2020
@bmw
Copy link
Member Author

bmw commented May 5, 2020

Haha nice work on getting Windows test coverage higher than on Linux/macOS.

I'm somewhat tempted to modify tox.cover.py to provide a separate case for macOS to keep our Linux coverage equal, but I personally don't think it's worth it right now.

@bmw
Copy link
Member Author

bmw commented May 5, 2020

Thanks for the review.

@bmw bmw merged commit 9154e79 into master May 5, 2020
7 checks passed
7 checks passed
Travis CI - Pull Request Build Passed
Details
limited-test-suite Build #20200504.5 succeeded
Details
limited-test-suite (test macos-py27) test macos-py27 succeeded
Details
limited-test-suite (test macos-py38) test macos-py38 succeeded
Details
limited-test-suite (test windows-integration-certbot) test windows-integration-certbot succeeded
Details
limited-test-suite (test windows-py35) test windows-py35 succeeded
Details
limited-test-suite (test windows-py37-cover) test windows-py37-cover succeeded
Details
@bmw bmw deleted the drop-min-coverage-certbot branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.