Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng update @angular/cli also updates angular core #37741

Open
markgoho opened this issue Jun 25, 2020 · 5 comments
Open

ng update @angular/cli also updates angular core #37741

markgoho opened this issue Jun 25, 2020 · 5 comments
Labels
Milestone

Comments

@markgoho
Copy link
Contributor

@markgoho markgoho commented Jun 25, 2020

Upgrade instructions read: ng update @angular/cli @angular/core but it would appear that the @angular/core part is redundant and is updated along with the cli. This can lead to confusion. Are we intentionally asking users to enter commands that aren't needed?

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Jun 25, 2020

@markgoho, that's a good point. Maybe someone from the dev-rel team knows why?

//cc @mgechev & @StephenFluin.

Moving it to Angular/Angular since it's more of a documentation issue.

@alan-agius4 alan-agius4 transferred this issue from angular/angular-cli Jun 25, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jun 25, 2020
@IgorMinar
Copy link
Member

@IgorMinar IgorMinar commented Jun 25, 2020

As of v9 (angular/angular-cli@be21077#diff-078217c29c514afed6a8d9ef7a0ebd74R89) the cli has an indirect peer dep (via @angular-devkit/build-angular) on @angular/compiler-cli which depends on @angular/core.

Because of this change, we no longer need to specify both @angular/core and @angular/cli in the ng update command.

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Jun 25, 2020

@IgorMinar, should we update the docs and update guide?

@IgorMinar
Copy link
Member

@IgorMinar IgorMinar commented Jun 26, 2020

Does ng update @angular/core also update both the FW and CLI?

I haven't tested it but it might work.

If it does then it would be better to document that so that it's clear that you are updating the core and its dependencies and not just the CLI.

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Jun 26, 2020

Does ng update @angular/core also update both the FW and CLI?

No, because @angular/core don't have a peer dependencies on Angular CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.