phi

It is not surprising that deep and shallow scan show different results. Shallow scan only looks at column names. Deep scan looks at a sample of the data. I've even noticed that two different runs of deep scan show different results as sample rows are different. This is the challenge with not scanning all of the data. Its a trade-off between performance/cost and accuracy. There is no right answer.

As part of the test cleanup we added rubocop and created exceptions in https://github.com/apsislabs/phi_attrs/blob/master/.rubocop.yml to not impact existing behavior.

In the PR for this each of the # TODO: RUBOCOP should be an individual commit that removes the exception and fixes the offending file so that we can do a step by step comparison.