Skip to content

/ rules_python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable buildifier presubmit check #245

Merged
merged 8 commits into from Oct 23, 2019
Merged

Enable buildifier presubmit check #245

merged 8 commits into from Oct 23, 2019

Conversation

@hlopko
Copy link
Member

@hlopko hlopko commented Oct 23, 2019 •
edited

This PR enables all buildifier checks on presubmit, plus it migrates the repo to fix violations.
@hlopko
Enable buildifier presubmit check
Loading status checks…
710febc
hlopko added 4 commits Oct 23, 2019
@hlopko
Run buildifier
Loading status checks…
1207ed4
@hlopko
Run buildifier fix all
Loading status checks…
de53403
@hlopko
Fix some more
Loading status checks…
110c95a
@hlopko
And final polish
Loading status checks…
fffcff8
@hlopko hlopko requested a review from brandjon Oct 23, 2019
@hlopko hlopko marked this pull request as ready for review Oct 23, 2019
@hlopko hlopko requested a review from lberki as a code owner Oct 23, 2019
@lberki
lberki approved these changes Oct 23, 2019
View changes
@brandjon
brandjon requested changes Oct 23, 2019
View changes
Copy link
Member

@brandjon brandjon left a comment

I'll integrate my comments...
experimental/python/wheel.bzl Outdated Show resolved Hide resolved
python/defs.bzl Show resolved Hide resolved
python/private/reexports.bzl Outdated Show resolved Hide resolved
brandjon added 2 commits Oct 23, 2019
@brandjon
Revert or modify some formatting changes
Loading status checks…
a4a3106
@brandjon
Apply buildifier again
Loading status checks…
0a4cb59
@brandjon
brandjon approved these changes Oct 23, 2019
View changes
@brandjon
Bugfix helper func
Loading status checks…
6219578
@brandjon brandjon merged commit 230f6d1 into bazelbuild:master Oct 23, 2019
2 checks passed
2 checks passed
buildkite/rules-python-python Build #487 passed (46 seconds)
Details
cla/google All necessary CLAs are signed
@brandjon
Copy link
Member

@brandjon brandjon commented Oct 23, 2019

Thanks for the PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandjon brandjon

@lberki lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@hlopko @brandjon @lberki @googlebot
You can’t perform that action at this time.