Skip to content

/ scientist

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused attribute #119

Merged
merged 1 commit into from Jun 2, 2020
Merged

Remove unused attribute #119

merged 1 commit into from Jun 2, 2020

Conversation

@ptrykov
Copy link
Contributor

@ptrykov ptrykov commented Jun 2, 2020 •
edited

Remove unused now attribute accessor from Scientist::Observation class.

Since 39c495d got merged, now attribute accessor is not used anywhere in the codebase and can be safely removed.
@ptrykov
Unused attribute removed
Loading status checks…
b790308
@coveralls
Copy link

@coveralls coveralls commented Jun 2, 2020

Coverage Status

Coverage remained the same at 99.107% when pulling b790308 on ptrykov:ptrykov/unused-attribute into 7b4843f on github:master.
@zerowidth
zerowidth approved these changes Jun 2, 2020
View changes
@zerowidth zerowidth merged commit 04dd1ba into github:master Jun 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ptrykov ptrykov deleted the ptrykov:ptrykov/unused-attribute branch Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerowidth zerowidth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ptrykov @coveralls @zerowidth
You can’t perform that action at this time.