Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-select in query history view #454

Closed
aeisenberg opened this issue Jun 16, 2020 · 0 comments · Fixed by #456
Closed

Allow multi-select in query history view #454

aeisenberg opened this issue Jun 16, 2020 · 0 comments · Fixed by #456
Labels
enhancement New feature or request

Comments

@aeisenberg
Copy link
Contributor

Some commands in the query history view make sense to support multiple items:

  • codeQLQueryHistory.removeHistoryItem --- we should be able to remove multiple items at once
  • codeQLQueryHistory.compareWith --- if exactly two items are selected, the compare view should focus on the two of them (if they are compatible queries)

I would like to ensure that when there is multi-select, only the appropriate commands are active, but due to microsoft/vscode#99767, this feature has not been implemented in vscode. So, we will just have to throw an error if the wrong number of items are selected for a query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant