v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API #271

wranai · 2018-05-02T21:34:49Z

v1 and v3 are treated as if they were related to public vs private (and widthraw) calls:

Lines 17 to 19 in 852b256

    
           PUBLIC_API_VERSION = 'v1' 
        
           PRIVATE_API_VERSION = 'v3' 
        
           WITHDRAW_API_VERSION = 'v3'

I believe this is a mistake, proven by that the v1 ticker endpoints (used by the client) have been retired in favor of v3 versions with the same functionality:

v1/ticker/allPrices => v3/ticker/price
v1/ticker/allBookTickers => v3/ticker/bookTicker

#270 may be the result of undocumented changes to the (now unofficial) v1 endpoints that the client is still using:

python-binance/binance/client.py

Line 407 in 852b256

return self._get('ticker/allPrices')

python-binance/binance/client.py

Line 438 in 852b256

return self._get('ticker/allBookTickers')

Both of the above functions reference documentation that no longer exists.

EDIT: the v3 version is probably just an alias to v1 because it exhibits the same bug that #270 is about.

aghamir · 2018-07-03T18:34:34Z

Is there any progress in this issue?

wranai changed the title ~~v1 vs v3 are not about public vs private calls, and~~ v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API May 2, 2018

sammchardy / python-binance

v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API #271

v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API #271

wranai commented May 2, 2018 •

edited

aghamir commented Jul 3, 2018

sammchardy / python-binance

Join GitHub today

v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API #271

v1 vs v3 are not about public vs private calls, and ticker calls use obsolete API #271

Comments

wranai commented May 2, 2018 • edited

aghamir commented Jul 3, 2018

Essential cookies

Always active

Analytics cookies

wranai commented May 2, 2018 •

edited