Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upchanging description and example to add more clarification #322
Conversation
add more clarification
|
"add more clarification" PR description is misleading. You change example itself.
Please take these comments just as an opinion and a ground for discussion. |
| class MakeBoldCommand(Command): | ||
| """ | ||
| A simple command to bold a text. | ||
| """ | ||
|
|
||
| def execute(self): |
faif
Mar 12, 2020
•
Owner
To show the effect of the command it is good to have some definition of bold. Maybe in this case wrap the text with the HTML <b> or <strong> element. The same goes for italic.
To show the effect of the command it is good to have some definition of bold. Maybe in this case wrap the text with the HTML <b> or <strong> element. The same goes for italic.
h4ppysmile
changed the title
|
Hi guys! |
| def rename(self, src, dest): | ||
| print("renaming {} to {}".format(src, dest)) | ||
| os.rename(src, dest) | ||
| def on_do_press(self, filename): |
gyermolenko
Mar 15, 2020
Contributor
I think names like on_do_press and on_undo_press are harder to read then rename, delete or whatever else
I think names like on_do_press and on_undo_press are harder to read then rename, delete or whatever else
h4ppysmile
Mar 15, 2020
Author
Contributor
You are right, but the invoker (here is the menu item) does not know what is going to do.
Am I right?
You are right, but the invoker (here is the menu item) does not know what is going to do.
Am I right?
|
Can we think of example without actual os files manipulations? Deleting files is a bit dangerous and not really necessary here. |
add more clarification