Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage on macOS #7973

Open
bmw opened this issue May 5, 2020 · 0 comments
Open

Test coverage on macOS #7973

bmw opened this issue May 5, 2020 · 0 comments

Comments

@bmw
Copy link
Member

@bmw bmw commented May 5, 2020

When working on other things, I found that our coverage tests were failing on master on macOS. I quickly fixed this in #7972, but there's nothing stopping us from hitting this problem again in the future. I think we should avoid this because it can be a confusing/frustrating experience, especially for new Certbot developers, to investigate test failures on their local changes only to find the tests don't even work on master.

To resolve it, I think we should run our coverage tests on macOS in CI. I think this can be done instead of our normal unit tests since our coverage tests just run our unit tests while measuring code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.