Skip to content

Remove VulnerablePackage.ql#3700

Closed
rneatherway wants to merge 1 commit into
github:masterfrom
rneatherway:remove-cs-use-of-vulnerable-package
Closed

Remove VulnerablePackage.ql#3700
rneatherway wants to merge 1 commit into
github:masterfrom
rneatherway:remove-cs-use-of-vulnerable-package

Conversation

@rneatherway
Copy link
Copy Markdown
Contributor

This query seems to be made redundant by dependabot.

This query seems to be made redundant by dependabot.
@rneatherway rneatherway requested review from a team and jf205 as code owners June 12, 2020 09:50
@calumgrant
Copy link
Copy Markdown
Contributor

I agree that we certainly don't want to be running this query by default on GitHub as it just duplicates what we already have.

@calumgrant
Copy link
Copy Markdown
Contributor

calumgrant commented Jun 12, 2020

However, wouldn't it be better to turn the query off rather than to delete it entirely?

We could also think about improving the query by for example checking for uses of the vulnerable API in conjunction with the package version?

@max-schaefer
Copy link
Copy Markdown
Contributor

We could also think about improving the query by for example checking for uses of the vulnerable API in conjunction with the package version?

We have an example of such a query for the special case of prototype pollution in JavaScript (https://github.com/github/codeql/blob/master/javascript/ql/src/Security/CWE-400/PrototypePollution.ql) and it is apparently massively popular with customers.

@rneatherway
Copy link
Copy Markdown
Contributor Author

So it seems like adding an exclusion filter like https://github.com/github/codeql/blob/master/cpp/ql/src/codeql-suites/exclude-slow-queries.yml might be a good place to start? Would you prefer that?

@rneatherway
Copy link
Copy Markdown
Contributor Author

As the less disruptive option I have opened #3736

@rneatherway rneatherway deleted the remove-cs-use-of-vulnerable-package branch May 7, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants