JS: Add query to detect sensitive information flowing into compiled artifact#3661
Merged
Conversation
asgerf
reviewed
Jun 9, 2020
Co-authored-by: Asger F <asgerf@github.com>
asgerf
reviewed
Jun 15, 2020
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Just a few minor things, otherwise LGTM 👍
Co-authored-by: Asger F <asgerf@github.com>
asgerf
reviewed
Jun 16, 2020
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
LGTM
@mchammer01 request for doc review
mchammer01
approved these changes
Jun 17, 2020
Contributor
mchammer01
left a comment
mchammer01
left a comment
There was a problem hiding this comment.
@erik-krogh - this is looking great, just a tiny comment ✨
| <sample src="examples/build-leak-fixed.js"/> | ||
| </example> | ||
| <references> | ||
| <li>webpack: <a href="https://webpack.js.org/plugins/define-plugin/">DefinePlugin API</a></li> |
Contributor
There was a problem hiding this comment.
Missing full stop at the end of this bullet point
asgerf
approved these changes
Jun 17, 2020
This was referenced Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE status:
CVE-2020-11059: TP/TN
CVE-2017-16225: TP/TP
Adds a query that detects sensitive information flowing to
webpack.DefinePlugin().This sensitive information ends up being part of the compiled JavaScript file.
Example TP.
Any naming suggestions are very welcome, I'm not impressed by my own naming.
TODO (post sprint):