Skip to content

/ date-fns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated webpack documentation #1697

Open
psimk opened this issue Mar 30, 2020 · 7 comments
Open

Outdated webpack documentation #1697

psimk opened this issue Mar 30, 2020 · 7 comments
Assignees
@dkozickis
Labels
🌏 I18n 📑 Needs docs update

Comments

@psimk
Copy link

@psimk psimk commented Mar 30, 2020

It seems like the webpack documentation is currently out of date.

For one, it references a locale, which was available in pre v2 versions of date-fns (the en locale to be specific).

Furthermore, post v2 date-fns locales now contain .d.ts and .md files, which make the documented ContextReplacementPlugin spit out a nasty warning:

image

P.S. I'd like to end this issue with thanking all the contributors for maintaining this package, it has been really useful on the project I am working on. I hope it gets picked up by more developers!
@r3d4rmy
Copy link

@r3d4rmy r3d4rmy commented Apr 5, 2020

Considering that these warnings appear for every locale contained within the Regular Expression passed into the ContextReplacementPlugin, this can really clutter up the terminal on application run. I'm also looking for a solution/updated documentation to this as I have multiple languages in use.
@dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 1, 2020

Can you guys (@psimk or @r3d4rmy) provided a reproducer repo?
I'm willing to investigate required settings, but settings up webpack from zero is not my strength :)
@dkozickis dkozickis self-assigned this May 1, 2020
@psimk
Copy link
Author

@psimk psimk commented May 1, 2020

@dkozickis Here you go repo.
I hope that the README/internal code is explanatory enough.
@dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 1, 2020

Thanks! I’ll have a look.
@dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 5, 2020

Ah wait, so you have a solution @psimk :D

Would you like to do a quick PR?
@pawel-marciniak
Copy link

@pawel-marciniak pawel-marciniak commented May 21, 2020

Any ona has a correct configuration for this?
@kossnocorp
Copy link
Member

@kossnocorp kossnocorp commented May 21, 2020 •
edited

@pawel-marciniak I've just enabled GitHub Discussions and I encourage you to ask the question here: https://github.com/date-fns/date-fns/discussions.

Please make sure you include a description of your problem.
@psimk psimk mentioned this issue Jun 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkozickis dkozickis

Labels
🌏 I18n 📑 Needs docs update
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@kossnocorp @dkozickis @r3d4rmy @psimk @pawel-marciniak
You can’t perform that action at this time.