Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fate of v1 parse implementation in v2 docs #1601

Open
icleolion opened this issue Jan 16, 2020 · 0 comments · May be fixed by #1605
Open

Fate of v1 parse implementation in v2 docs #1601

icleolion opened this issue Jan 16, 2020 · 0 comments · May be fixed by #1605

Comments

@icleolion
Copy link
Contributor

@icleolion icleolion commented Jan 16, 2020

parseISO v2 documentation currently states

The previous parse implementation was renamed to parseISO.

parse v2 documentation currently states

Old parse was renamed to toDate. Now parse is a new function which parses a string using a provided format.

I think considering the sentence is to divert people who have previously been using v1 parse to the correct v2 equivalent, it only needs to exist in docs for parse. If the sentence exists on parseISO, it should appear on toDate also.

Additionally I think the sentence would benefit from a more detailed explanation of what happened to the old parse method. Would this suffice

The v1 parse implementation was split into two functions. If you have a date|timestamp you should use toDate. If you have a string in ISO 8601 format then you should use parseISO. For strings in other formats you should use the new parse implementation which will parse the string using a provided format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.