Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing permissions behaviour when logged in as low-privilege user #11758

Open
ErisDS opened this issue Apr 20, 2020 · 3 comments
Open

Confusing permissions behaviour when logged in as low-privilege user #11758

ErisDS opened this issue Apr 20, 2020 · 3 comments

Comments

@ErisDS
Copy link
Member

@ErisDS ErisDS commented Apr 20, 2020

When you're logged in as E.g. an author, the admin panel isn't good at telling you why you can't edit a post. I've found two specific cases - the /edit URL and search, but I think they are both very similar.

To Reproduce

Case 1: search

  1. In admin search for a post you can't edit
  2. See the post listed in the results
  3. Click on the post
  4. You are taken to the posts list with no explanation

Case 2: /edit

  1. In the frontend, find that post you're trying to edit
  2. Add /edit to the end of the URL
  3. Watch the post screen load for a while
  4. You are taken to the posts list with no explanation

In both cases, there should be IMO a banner error saying you don't have permission.

In the case of search, we probably shouldn't be showing post the user can't edit at all?

Technical details:

  • Ghost Version: latest
@akshitproothi
Copy link

@akshitproothi akshitproothi commented Jun 9, 2020

I'm a first time contributor and would like to work on this. How do i get started?

@ErisDS
Copy link
Member Author

@ErisDS ErisDS commented Jun 9, 2020

We have a contributing guide as per most repositories. We don’t have anyone to coach you through issues, so you may want to start with an issue marked help wanted as these are the ones we think are suitable for contributors.

@akshitproothi
Copy link

@akshitproothi akshitproothi commented Jun 11, 2020

Good to know @ErisDS thanks, I’ll find one of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.