Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: update docker versions used in CI #2563

Merged
merged 1 commit into from Jun 11, 2020

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 3, 2020

CircleCI now has 19.03; https://circleci.com/docs/2.0/building-docker-images/#docker-version

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #2563 into master will increase coverage by 1.22%.
The diff coverage is 73.40%.

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
+ Coverage   56.78%   58.01%   +1.22%     
==========================================
  Files         311      295      -16     
  Lines       21832    21135     -697     
==========================================
- Hits        12398    12261     -137     
+ Misses       8519     7974     -545     
+ Partials      915      900      -15     
@thaJeztah
Copy link
Member Author

@thaJeztah thaJeztah commented Jun 3, 2020

Copy link
Collaborator

@vdemeester vdemeester left a comment

LGTM 🐯

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

LGTM

@silvin-lubecki silvin-lubecki merged commit 4f63781 into docker:master Jun 11, 2020
6 checks passed
6 checks passed
DCO DCO
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@thaJeztah thaJeztah deleted the thaJeztah:bump_circleci_docker branch Jun 11, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.