bpo-40889: special-case dict.items() ^ dict.items() for performance #20718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Jun 9, 2020
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane
reviewed
Jun 9, 2020
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
This reverts commit 1ef9f93.
rhettinger
approved these changes
Jun 10, 2020
| return NULL; | ||
| } | ||
|
|
||
| PyObject *key = NULL, *val1 = NULL, *val2 = NULL; |
There was a problem hiding this comment.
I generally expect these declarations to go at the top of the function (it's not required but it is the usual style in our C code).
|
Aside from the stylistic clean-ups of moving the declarations to the top of the function, this all looks fine to me. Will wait for Inada to take another look. |
|
This PR doesn't check that d2 size is changed during iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue40889