Skip to content

/ javascript-sdk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Create issue template #157

Merged
merged 3 commits into from Dec 26, 2018
Merged

chore(repo): Create issue template #157

merged 3 commits into from Dec 26, 2018

Conversation

@spencerwilson-optimizely
Copy link
Contributor

spencerwilson-optimizely commented Aug 22, 2018

I made this bespoke, but reviewers please let me know if you're aware of any prior art that you want to just adapt.

Is the Issue = Enhancement | Bug taxonomy comprehensive (for this SDK, at least)?
@spencerwilson-optimizely
chore(repo): Create issue template
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
188ea0e 
I made this bespoke, but reviewers please let me know if you're aware of any prior art that you want to just adapt.
@coveralls
Copy link

coveralls commented Aug 22, 2018 •
edited

Coverage Status

Coverage remained the same at 97.239% when pulling 6bb80e2 on sw/issue-template into 3ea6be2 on master.
@tylerbrandt
tylerbrandt reviewed Aug 22, 2018
View changes
.github/issue_template.md Outdated
@@ -0,0 +1,29 @@
Thanks for filing in issue! Are you proposing an enhancement or reporting a bug?

This comment has been minimized.

Sign in to view
@tylerbrandt

tylerbrandt Aug 22, 2018 Contributor

We should separate instructions from the content we want them to provide (GitHub supports <!-- comments --> for the former; see e.g. https://raw.githubusercontent.com/mishoo/UglifyJS2/master/.github/ISSUE_TEMPLATE.md; that way you don't have to delete a bunch of stuff.).
.github/issue_template.md Outdated

Any other relevant tools (like module bundlers, transpilers, etc.):

## Expected behavior

This comment has been minimized.

Sign in to view
@tylerbrandt

tylerbrandt Aug 22, 2018 Contributor

I like the three-part guide of "What were you trying to do?" (may help resolve X/Y problem issues), "What did you expect to happen?", "What actually happened?" I encountered something like this scheme recently when reporting an issue with npm and it was helpful.
@spencerwilson-optimizely
Restructure
Verified
This commit was signed with a verified signature.
spencerwilson-optimizely Spencer Wilson
GPG key ID: 913F22BF5A29B9BD Learn about signing commits
Loading status checks…
2ea98c9
@mikeng13
mikeng13 approved these changes Nov 6, 2018
View changes
Copy link
Collaborator

mikeng13 left a comment •
edited

Sorry I missed this PR before. Thanks for this. We do no yet a standard set but this seems like a good start. Please merge the latest master in.
@mikeng13
Merge branch 'master' into sw/issue-template
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6bb80e2
@mikeng13 mikeng13 merged commit fb0cd7a into master Dec 26, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.239%
Details
optimizely/fullstack-sdk-compatibility-suite (javascript) Build result: success
Details
@mikeng13 mikeng13 deleted the sw/issue-template branch Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbrandt tylerbrandt

@mikeng13 mikeng13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@spencerwilson-optimizely @coveralls @tylerbrandt @mikeng13
You can’t perform that action at this time.