Skip to content

/ Ghost

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save warning displayed when no changes made to Design settings #11590

Open
frantzypants opened this issue Feb 11, 2020 · 2 comments
Open

Save warning displayed when no changes made to Design settings #11590

frantzypants opened this issue Feb 11, 2020 · 2 comments
Labels
admin-client bug

Comments

@frantzypants
Copy link

@frantzypants frantzypants commented Feb 11, 2020 •
edited by kevinansfield

Issue Summary

When clicking on a label or link path in the navigation, even if no changes are made, you are still presented with an alert asking if you are sure you want to leave when clicking to other areas of Ghost admin.

To Reproduce

  1. Go to the Design settings in Ghost admin
  2. Click inside the label of an existing navigation item
  3. Make no changes to the field, and click on "Posts" or any other location within the admin
  4. See warning notification

Technical details:

Version 3.5.2
Environment production
Database mysql
Browser/OS: Any
@TheodoreChu
Copy link

@TheodoreChu TheodoreChu commented Feb 19, 2020

Thank you, @frantzypants for writing this up. This occurs for both the primary and secondary navigation. The warning does not show if we click or type into the final empty "Label" box, but it does show if we click or type into the final corresponding link.
@stale
Copy link

@stale stale bot commented May 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the stale label May 20, 2020
@ErisDS ErisDS removed the stale label May 28, 2020
@rishabhgrg rishabhgrg assigned rishabhgrg and unassigned rishabhgrg Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin-client bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@kevinansfield @ErisDS @rishabhgrg @frantzypants @TheodoreChu
You can’t perform that action at this time.