Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Typing fixes #777
Open
Typing fixes #777
Conversation
blueyed
force-pushed the
blueyed:fix-typing
branch
2 times, most recently
from
24c5c61
to
6dfea84
blueyed
force-pushed the
blueyed:fix-typing
branch
2 times, most recently
from
9a4c14f
to
8fd1663
Tests are using `int` and `float` there, and it should be `Any` in general.
| @@ -10,6 +10,14 @@ | |||
| from starlette.types import Message, Receive, Scope, Send | |||
| from starlette.websockets import WebSocket | |||
|
|
|||
| if False: # TYPE_CHECKING | |||
florimondmanca
Mar 25, 2020
Member
There's a built-in flag in typing for this :-)
Suggested change
if False: # TYPE_CHECKING
if typing.TYPE_CHECKING:
There's a built-in flag in typing for this :-)
Suggested change
| if False: # TYPE_CHECKING | |
| if typing.TYPE_CHECKING: |
blueyed
Mar 25, 2020
Author
Contributor
Yes, makes sense (given that this is py36+), thanks!
Not going to update it for now though, given its staleness already.
Yes, makes sense (given that this is py36+), thanks!
Not going to update it for now though, given its staleness already.
|
What's the status of this PR? It contains the fix of one little typing annoyance I was going to suggest. |
| @@ -449,7 +449,7 @@ def websocket_connect( | |||
|
|
|||
| return session | |||
|
|
|||
| def __enter__(self) -> requests.Session: | |||
| def __enter__(self) -> "TestClient": | |||
and-semakin
Oct 2, 2020
Contributor
Would be nice to have this fix merged.
Would be nice to have this fix merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mypy starlette tests --ignore-missing-imports --check-untyped-defspassed (except for #780).