Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handler run always #761

Open
wants to merge 2 commits into
base: master
from

Conversation

@aviramha
Copy link
Contributor

@aviramha aviramha commented Dec 18, 2019

No description provided.

aviramha added 2 commits Dec 17, 2019
merge from head
@aviramha
Copy link
Contributor Author

@aviramha aviramha commented Dec 18, 2019

Should I add a test that checks in case a response started that the handler is still called?

@aviramha
Copy link
Contributor Author

@aviramha aviramha commented Dec 27, 2019

@tomchristie Thoughts?

@florimondmanca
Copy link
Member

@florimondmanca florimondmanca commented Jan 11, 2020

@aviramha I'm not sure I understand the use case here. Can you clarify why we'd want/need to move the call to the installed error handler separately from the other cases?

@aviramha
Copy link
Contributor Author

@aviramha aviramha commented Jan 11, 2020

@aviramha I'm not sure I understand the use case here. Can you clarify why we'd want/need to move the call to the installed error handler separately from the other cases?

The use case are exception handlers not being called on background tasks since the response already started. This changes the logic so the handlers will be called even if response is returned. It's extremely important for usage of error loggers like sentry etc.

@aviramha
Copy link
Contributor Author

@aviramha aviramha commented Jan 24, 2020

Any update? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.