Skip to content

/ lacinia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selects-field? should respect include/skip directives #319

Closed
nimaai opened this issue Apr 28, 2020 · 1 comment
Closed

selects-field? should respect include/skip directives #319

nimaai opened this issue Apr 28, 2020 · 1 comment
Assignees
@hlship
Labels
bug
Milestone
0.37.0

Comments

@nimaai
Copy link

@nimaai nimaai commented Apr 28, 2020

At least in my opinion.

Means, return false, if:

field @include(if: false)

Or at least there should be some equivalent to find out, if the field is asked for by the client or not.
@hlship
Copy link
Contributor

@hlship hlship commented Jun 5, 2020

Note that directives take effect during prepare-with-query-variables so I can do this, but it will only work after that call (which means if you are depending on this before query execution begins, you need to deal with the prepare step first).
@hlship hlship self-assigned this Jun 5, 2020
@hlship hlship added this to the 0.37.0 milestone Jun 5, 2020
@hlship hlship added the bug label Jun 5, 2020
hlship added a commit that referenced this issue Jun 5, 2020
@hlship
Check for directives in preview api
21f653f 
Fixes #319
@hlship hlship mentioned this issue Jun 5, 2020
Merged
@hlship hlship closed this in #324 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlship hlship

Labels
bug
Milestone
0.37.0
Linked pull requests

Successfully merging a pull request may close this issue.

Check for directives in the preview api
2 participants
@hlship @nimaai
You can’t perform that action at this time.