Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vega (not just Vega Lite) #945

Open
tvst opened this issue Jan 8, 2020 · 7 comments
Open

Add support for Vega (not just Vega Lite) #945

tvst opened this issue Jan 8, 2020 · 7 comments

Comments

@tvst
Copy link
Collaborator

@tvst tvst commented Jan 8, 2020

@mmcguffi
Copy link

@mmcguffi mmcguffi commented Feb 16, 2020

Looking forward to this feature! Since vega-lite is converted into vega, it should be fairly straightforward?

@andfanilo
Copy link
Contributor

@andfanilo andfanilo commented Feb 16, 2020

There's a similar issue #483 where the use of vega-embed is proposed.

I'm willing to look into it and push a MVP PR by the end of next week to discuss it further if nobody has picked it. @tvst if you have any concerns or tips on how you would architecture that I'm all ears :).

@domoritz
Copy link
Member

@domoritz domoritz commented Feb 26, 2020

You could probably pass a Vega spec to the Vega-Lite view and it should almost work since the Vega-Lite component used Vega-Embed (https://github.com/streamlit/streamlit/blob/develop/frontend/src/components/elements/VegaLiteChart/VegaLiteChart.tsx#L268).

@mmcguffi
Copy link

@mmcguffi mmcguffi commented Feb 26, 2020

@domoritz I dont have a working example right now, but when I tried this it did not work

@domoritz
Copy link
Member

@domoritz domoritz commented Feb 26, 2020

That's why I said "almost" ;-) But the code paths should be very similar if anyone is going to implement support for Vega.

@andfanilo
Copy link
Contributor

@andfanilo andfanilo commented Feb 27, 2020

Hey @mmcguffi,

I've got a minimal implementation on a branch (just copied and edited the VegaLite code path). Do you by any chance have some Vega spec you want me to test ?

@mmcguffi
Copy link

@mmcguffi mmcguffi commented Mar 1, 2020

Hey @andfanilo -- sorry for the delay! This is the example I had previously try get get Streamlit to render: https://vega.github.io/editor/#/examples/vega/donut-chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.