Skip to content

build: use @bazel/bazelisk rather than @bazel/bazel#17718

Closed
josephperrott wants to merge 1 commit into
angular:9.1.xfrom
josephperrott:use-bazelisk
Closed

build: use @bazel/bazelisk rather than @bazel/bazel#17718
josephperrott wants to merge 1 commit into
angular:9.1.xfrom
josephperrott:use-bazelisk

Conversation

@josephperrott
Copy link
Copy Markdown
Member

Migrates to using @bazel/bazelisk rather than @bazel/bazel as the
latter is being deprecated. @bazel/bazelisk is a drop in
replacement for @bazel/bazel.

Migrates to using @bazel/bazelisk rather than @bazel/bazel as the
latter is being deprecated.  @bazel/bazelisk is a drop in
replacement for @bazel/bazel.
@josephperrott josephperrott added area: etc/misc target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels May 13, 2020
@josephperrott josephperrott requested a review from clydin May 13, 2020 17:37
@filipesilva
Copy link
Copy Markdown
Contributor

@josephperrott this is marked for merge but it's failing on the bazel test. Are you sure you want to make this change though? Master is already on bazelisk.

@josephperrott
Copy link
Copy Markdown
Member Author

I can look at the failure, I originally made the @bazel/bazelisk PR to target both master and patch, but was told that it couldn't cherry-pick cleanly into patch. I will have to investigate what is happening on this PR.

@alan-agius4 alan-agius4 removed the action: merge The PR is ready for merge by the caretaker label May 20, 2020
@alan-agius4
Copy link
Copy Markdown
Collaborator

Closing as we are already using bazelisk

@josephperrott josephperrott deleted the use-bazelisk branch August 25, 2020 16:01
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: etc/misc target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants