Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation errors in assert Equalvaluesf and Exactlyf #927

Open
lk16 opened this issue Apr 18, 2020 · 1 comment
Open

Documentation errors in assert Equalvaluesf and Exactlyf #927

lk16 opened this issue Apr 18, 2020 · 1 comment

Comments

@lk16
Copy link

@lk16 lk16 commented Apr 18, 2020

Hi everyone!

First of all thanks for making and maintaining this great package.

I found a small issue in the docs, it says
assert.EqualValuesf(t, uint32(123, "error message %s", "formatted"), int32(123))
which is obviously invalid code. I found it at:
https://github.com/stretchr/testify/blob/master/assert/assertion_format.go#L96

A similar issue can be found here.
https://github.com/stretchr/testify/blob/master/assert/assertion_format.go#L130

I am up for checking any other issues and submitting a PR with fixes myself.
I am writing here so you guys are aware and to check if it hasn't been fixed yet by someone else.
It is present on master and I couldn't find any tickets mentioning this issue.

@mvdkleijn
Copy link
Collaborator

@mvdkleijn mvdkleijn commented Apr 23, 2020

Hi, don't think anyone reported this before. Feel free to submit a PR. Looks a little like copy-n-paste gone wrong. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.