fix: dont default to Font.default#8401
Merged
Merged
Conversation
This would cause a font to be set for any label even when using default system font. This will also cause a typeface which is pretty long
Contributor
|
@farfromrefug can you please update your branch? Thanks! |
Contributor
|
@farfromrefug can you please fix the following linter errors: |
Contributor
|
ping @farfromrefug , can you update your branch and fix the linter errors :) |
Contributor
|
@farfromrefug can you check the following PR - Akylas#2 |
Added null font guards and updated to master branch
Collaborator
Author
|
@vtrifonov awesome. Sorry about that :s |
vtrifonov
approved these changes
Apr 2, 2020
Contributor
|
@farfromrefug one more PR to merge Akylas#3 :) |
fix: Used default bold for TabView
Collaborator
Author
|
@vtrifonov what test is that that showed the bold font error for tabs? Maybe i could run that on my side and save you some time ... |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix: dont default to Font.default This would cause a font to be set for any label even when using default system font. This will also cause a typeface which is pretty long * lint: lint fixes * fix: added null font guards * fix: Used default bold for TabView Co-authored-by: Vasko <v.trifonov@gmail.com>
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* fix: dont default to Font.default This would cause a font to be set for any label even when using default system font. This will also cause a typeface which is pretty long * lint: lint fixes * fix: added null font guards * fix: Used default bold for TabView Co-authored-by: Vasko <v.trifonov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would cause a font to be set for any label even when using default system font.
This will also cause a typeface creation which is pretty long
This PR also add a new optional behavior. In my
nativescript-htmllabelthetextSizeis handled by the component and not usingFont. To make things faster i would need the fontSizeProperty not to create afontInternalas it would create nativetypeface.So this PR checks for
handleFontSizeproperty on theView.If you prefer it done another way i am happy to change it.