Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to TypeScript (no runtime code changes) #410

Merged
merged 33 commits into from May 25, 2020
Merged

Conversation

@Shinigami92
Copy link
Member

Shinigami92 commented May 19, 2020

Short description of what this resolves:

We want to create a stable code base in which errors can be identified quickly

Proposed changes:

  • Rewrite the project with typescript

closes #202
closes #277

@Shinigami92 Shinigami92 added the chore label May 19, 2020
@Shinigami92 Shinigami92 requested a review from thedaviddias May 19, 2020
@Shinigami92 Shinigami92 self-assigned this May 19, 2020
@Shinigami92 Shinigami92 added this to In progress in 1.0.0 via automation May 19, 2020
@Shinigami92
Copy link
Member Author

Shinigami92 commented May 19, 2020

First experimental branch: https://github.com/htmlhint/HTMLHint/tree/chore/typescript-sub-1

I created an initial process workflow to leave our current rollup build unchanged

Shinigami92 added 13 commits May 19, 2020
@Shinigami92
Copy link
Member Author

Shinigami92 commented May 20, 2020

@thedaviddias I think I want to request a first review!

There are still errors and warnings, but from now on it might be that we need to change code!
So we may push this into a beta branch?

eslint is currently configured to allow warnings so the build can be triggered
The tests are green and I didn't touched the tests!

@Shinigami92 Shinigami92 changed the base branch from develop to beta May 21, 2020
@Shinigami92 Shinigami92 marked this pull request as ready for review May 21, 2020
@Shinigami92
Copy link
Member Author

Shinigami92 commented May 21, 2020

For now I disabled some eslint rules and added some TODOs to resolve them later

This PR didn't touched runtime-code
This will be made in a next PR so we can track the changes in a better and more readable way

Shinigami92 added 7 commits May 21, 2020
@Shinigami92
Copy link
Member Author

Shinigami92 commented May 22, 2020

I have improved linting for the project so test folder is also linted with typescript checking and I improved linting with type-checking enabled.

.eslintignore Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
build.js Outdated Show resolved Hide resolved
1.0.0 automation moved this from In progress to Reviewer approved May 25, 2020
@Shinigami92 Shinigami92 changed the title chore: typescript chore: migrate to TypeScript (no runtime code changes) May 25, 2020
1.0.0 automation moved this from Reviewer approved to Review in progress May 25, 2020
@Shinigami92 Shinigami92 requested a review from thedaviddias May 25, 2020
1.0.0 automation moved this from Review in progress to Reviewer approved May 25, 2020
@Shinigami92 Shinigami92 merged commit bdd82b5 into beta May 25, 2020
19 checks passed
19 checks passed
build (10.x, ubuntu-latest)
Details
build (10.x, ubuntu-latest)
Details
build (10.x, macOS-latest)
Details
build (10.x, macOS-latest)
Details
build (10.x, windows-latest)
Details
build (10.x, windows-latest)
Details
build (12.x, ubuntu-latest)
Details
build (12.x, ubuntu-latest)
Details
build (12.x, macOS-latest)
Details
build (12.x, macOS-latest)
Details
build (12.x, windows-latest)
Details
build (12.x, windows-latest)
Details
build (14.x, ubuntu-latest)
Details
build (14.x, ubuntu-latest)
Details
build (14.x, macOS-latest)
Details
build (14.x, macOS-latest)
Details
build (14.x, windows-latest)
Details
build (14.x, windows-latest)
Details
Semantic Pull Request ready to be squashed
Details
1.0.0 automation moved this from Reviewer approved to Done May 25, 2020
@Shinigami92 Shinigami92 deleted the chore/typescript branch May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.0.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.