Skip to content

/ electron

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron.ClientRequest should be typed as a WritableStream #22730

Open
MarshallOfSound opened this issue Mar 17, 2020 · 1 comment
Open

Electron.ClientRequest should be typed as a WritableStream #22730

MarshallOfSound opened this issue Mar 17, 2020 · 1 comment
Labels
component/typescript documentation 📓

Comments

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Mar 17, 2020

In order to allow typescript usage of stream.pipe(request) (which works) the ClientRequest typescript definition needs to either be compatible with or extend Writable.

Extending probably makes the most sense if we can make that work as that's what we're actually doing in the code.
@MarshallOfSound
Copy link
Member Author

@MarshallOfSound MarshallOfSound commented Mar 17, 2020

Also ReadableStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/typescript documentation 📓
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@MarshallOfSound
You can’t perform that action at this time.