Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanges introduced to string quoting in responses #1499
Labels
Comments
Closed
|
This change broke a bunch of tests for me, and it took quite a while to figure out what was wrong. Looks like there's no changelog entry for this, even though it's very breaking. Is the intention to keep it this way? Can this be added to the logs? |
|
Running across this. I can't find out if this was a permanent behavior change or is a bug which will be fixed in a subsequent release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thank you for maintaining this wonderful project!
We've been running CI tests on our product that uses click, and tests for command-line stumbled upon a change in output representation introduced in "manual cleanup" commit.
I do not see this as an issue in click, but it took some time to find the origin, and so I suggest to mention effects of this change in documentation or changelog.
Thank you!
Expected Behavior
Previously a missing option string was displayed with double-quotes:
Actual Behavior
Now a missing option string is displayed with single-quotes, as per repr() implementation:
Environment