Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extend angularCompilerOptions in tsconfig from absolute tsconfig #36715

Closed
splincode opened this issue Apr 20, 2020 · 3 comments
Closed

Support extend angularCompilerOptions in tsconfig from absolute tsconfig #36715

splincode opened this issue Apr 20, 2020 · 3 comments
Labels
comp: compiler feature triage #1
Milestone
Backlog

Comments

@splincode
Copy link
Contributor

@splincode splincode commented Apr 20, 2020

🐞 bug report

@alan-agius4 #22684

Is this a regression?

No

Description

I know that extends works if we use a config regarding our file system

tsconfig.angular.json

{
      "angularCompilerOptions": {
        "strictTemplates": true,
        "fullTemplateTypeCheck": true,
        "annotateForClosureCompiler": true,
        "strictInjectionParameters": true,
        "skipTemplateCodegen": false,
        "preserveWhitespaces": true,
        "skipMetadataEmit": false,
        "disableTypeScriptVersionCheck": true
    }
}

tsconfig.json

{
    "extends": "./tsconfig.angular.json",
    "compilerOptions": {
        "baseUrl": "./src",
        "module": "esnext",
        "target": "es2015",
        "outDir": "./dist/out-tsc",
        "lib": ["es2017", "es2018", "dom"]
    }
}

Works great

But If I put the config in a separate package

{
    "extends": "@my-company/tsconfig",
    "compilerOptions": {
        "baseUrl": "./src",
        "module": "esnext",
        "target": "es2015",
        "outDir": "./dist/out-tsc",
        "lib": ["es2017", "es2018", "dom"]
    }
}

Only inheritance compilerOptions works, but I expect angularCompilerOptions to be inherited too

🔬 Minimal Reproduction

$ npm i @angular-ru/tsconfig

{
    "extends": "@angular-ru/tsconfig",
    "compilerOptions": {
        "baseUrl": "./src",
        "module": "esnext",
        "target": "es2015",
        "outDir": "./dist/out-tsc",
        "lib": ["es2017", "es2018", "dom"]
    }
}
$ ng build

Works without angularCompilerOptions inherited properties

@alan-agius4 What do you think about this, is it a bug?

🌍 Your Environment

Angular Version:

Angular 8.2.14
@ngbot ngbot bot added this to the needsTriage milestone Apr 20, 2020
@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 20, 2020 •
edited

Hi @splincode, since TypeScript supports non rooted extends, we should do the same.

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

@splincode
Copy link
Contributor Author

@splincode splincode commented Apr 20, 2020

@alan-agius4 Glad to hear that!

@alxhub alxhub added the feature label May 26, 2020
@ngbot ngbot bot removed this from the needsTriage milestone May 26, 2020
@ngbot ngbot bot added this to the Backlog milestone May 26, 2020
@alan-agius4 alan-agius4 mentioned this issue Jul 1, 2020
Closed
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 4, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
ec58d5c 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes angular#36715
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 4, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
d9ae713 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715
@alan-agius4 alan-agius4 mentioned this issue Feb 4, 2021
Closed
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 4, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
e55c465 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 8, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
7c02a06 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 8, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
55f2c18 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Feb 9, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from node
4dd5000 
TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715
@JounQin JounQin mentioned this issue Feb 24, 2021
Closed
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Mar 1, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from n 1�7
101ffe9 
…ode (angular#40694)

TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715

PR Close angular#40694

(cherry picked from commit 5eb1954)
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Mar 1, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from n 1�7
ec567ab 
…ode (angular#40694)

TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715

PR Close angular#40694

(cherry picked from commit 5eb1954)
alan-agius4 added a commit to alan-agius4/angular that referenced this issue Mar 1, 2021
@alan-agius4
fix(compiler-cli): extend angularCompilerOptions in tsconfig from n 1�7
2ef25d3 
…ode (angular#40694)

TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: angular#36715

PR Close angular#40694

(cherry picked from commit 5eb1954)
zarend added a commit that referenced this issue Mar 1, 2021
@alan-agius4 @zarend
fix(compiler-cli): extend angularCompilerOptions in tsconfig from n 1�7
e3ccd56 
…ode (#40694) (#41036)

TypeScript supports non rooted extends, we should do the same

https://github.com/microsoft/TypeScript/blob/b346f5764e4d500ebdeff7086e43690ea533a305/src/compiler/commandLineParser.ts#L2603-L2628

Closes: #36715

PR Close #40694

(cherry picked from commit 5eb1954)

PR Close #41036
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Merged
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 9, 2021
Closed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Mar 14, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
comp: compiler feature triage #1
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

fix(compiler-cli): readConfiguration existing options should override options in tsconfig
4 participants
@pkozlowski-opensource @alxhub @splincode @alan-agius4