Skip to content

JavaScript: Track require through local data flow.#3555

Merged
semmle-qlci merged 1 commit into
github:masterfrom
max-schaefer:js/require-flow
May 26, 2020
Merged

JavaScript: Track require through local data flow.#3555
semmle-qlci merged 1 commit into
github:masterfrom
max-schaefer:js/require-flow

Conversation

@max-schaefer
Copy link
Copy Markdown
Contributor

Occasionally helpful, though an evaluation on nightly doesn't show any changes in results. Performance is also unchanged.

@max-schaefer max-schaefer requested a review from a team as a code owner May 25, 2020 15:57
@max-schaefer
Copy link
Copy Markdown
Contributor Author

Given the lack of new results I didn't add a change note, but I'm happy to supply one if desired.

@asgerf
Copy link
Copy Markdown
Contributor

asgerf commented May 26, 2020

I can't access the report you shared.

@max-schaefer
Copy link
Copy Markdown
Contributor Author

Ah, apologies. I moved my dist-compare reports to a new repo, which I have now invited you (and the other codeql-javascripters) to.

Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@semmle-qlci semmle-qlci merged commit 4b0354c into github:master May 26, 2020
@max-schaefer max-schaefer deleted the js/require-flow branch July 2, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants