Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFeature request: Open links from doc pages in popup or new tab #36670
Comments
|
I'll pick this up. |
|
I want to work on this, but this will be my first open source contribution, can u pls guide me how to get the source code, so tht i can set it up in my local and give it a shot! |
|
Hi @Arpan619Banerjee , |
|
Sure! Thank you so much!
…On Sat, 23 May 2020, 12:00 am K Ramakrishna Vaidya, < ***@***.***> wrote:
Hi @Arpan619Banerjee <https://github.com/Arpan619Banerjee> ,
Checkout this link. This provides a good understanding of how to start
contributing to open source.
https://www.firsttimersonly.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36670 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO2GUXYK2QZ25Y23O46NW5DRS3AFFANCNFSM4MJZBM2A>
.
|
|
@jbogarthyde - actually @IgorMinar has always been against automatically opening links in new tabs, and I agree with him. Forcing external content in a new tab is a constraint on readers which they cannot workaround. Moving to a new tab also can be confusing as it appears that the browsing history was lost. It is quite straightforward for the reader to open a new tab on a link, for example on OS/X you just hold the Cmd button down while clicking. Now that we have additional visual indicators on all external links I think that this issue should be closed. WDYT? |
|
The external link marker is certainly helpful for actual external links -- the thing that concerns me most is Glossary definitions. I want to encourage the use of the Glossary, and it is annoying for a temporary reminder or reference to take you away from the page you are reading. The definition of a term should be an aid to understanding in the context of the term's usage. A pop-up would be the best solution. Is that possible? |
|
@jbogarthyde - I think you are requesting that when you click on a glossary link a small pop-up appears showing the definition of the term, without navigating to a new page at all? This is definitely doable - although it will require a bit of work on the docs-infra side. |
It would improve the user experience for doc pages to open external links in a separate tab, and glossary links in either a separate tab or a popup.