Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Open links from doc pages in popup or new tab #36670

Closed
jbogarthyde opened this issue Apr 16, 2020 · 8 comments
Closed

Feature request: Open links from doc pages in popup or new tab #36670

jbogarthyde opened this issue Apr 16, 2020 · 8 comments

Comments

@jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Apr 16, 2020

It would improve the user experience for doc pages to open external links in a separate tab, and glossary links in either a separate tab or a popup.

@ngbot ngbot bot added this to the needsTriage milestone Apr 16, 2020
@daftfox
Copy link

@daftfox daftfox commented Apr 22, 2020

I'll pick this up.

@Arpan619Banerjee
Copy link

@Arpan619Banerjee Arpan619Banerjee commented Apr 24, 2020

I want to work on this, but this will be my first open source contribution, can u pls guide me how to get the source code, so tht i can set it up in my local and give it a shot!

@kgrvaidya
Copy link

@kgrvaidya kgrvaidya commented May 22, 2020

Hi @Arpan619Banerjee ,
Checkout this link. This provides a good understanding of how to start contributing to open source.
https://www.firsttimersonly.com/

@Arpan619Banerjee
Copy link

@Arpan619Banerjee Arpan619Banerjee commented May 23, 2020

@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented May 24, 2020

@jbogarthyde - actually @IgorMinar has always been against automatically opening links in new tabs, and I agree with him. Forcing external content in a new tab is a constraint on readers which they cannot workaround. Moving to a new tab also can be confusing as it appears that the browsing history was lost.

It is quite straightforward for the reader to open a new tab on a link, for example on OS/X you just hold the Cmd button down while clicking. Now that we have additional visual indicators on all external links I think that this issue should be closed. WDYT?

@jbogarthyde
Copy link
Contributor Author

@jbogarthyde jbogarthyde commented May 25, 2020

The external link marker is certainly helpful for actual external links -- the thing that concerns me most is Glossary definitions. I want to encourage the use of the Glossary, and it is annoying for a temporary reminder or reference to take you away from the page you are reading. The definition of a term should be an aid to understanding in the context of the term's usage.

A pop-up would be the best solution. Is that possible?

@petebacondarwin
Copy link
Member

@petebacondarwin petebacondarwin commented May 26, 2020

@jbogarthyde - I think you are requesting that when you click on a glossary link a small pop-up appears showing the definition of the term, without navigating to a new page at all?

This is definitely doable - although it will require a bit of work on the docs-infra side.
Since this is a different requirement to this issue, I am going to close this one.
Can you open a new issue with this specific feature request?

@jbogarthyde
Copy link
Contributor Author

@jbogarthyde jbogarthyde commented May 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.