Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add world justice information to where.py #160

Closed
serhii73 opened this issue Oct 25, 2019 · 12 comments
Closed

Add world justice information to where.py #160

serhii73 opened this issue Oct 25, 2019 · 12 comments

Comments

@serhii73
Copy link
Owner

@serhii73 serhii73 commented Oct 25, 2019

https://github.com/place2live/place2live/blob/master/world_justice_project/world_justice.csv
Can you add this information to where.py?
We need to create a new column in the ready data frame and put information about world justice in this country and this ranking place.
For example:

Finland, ......., 3/126

Thank you very much!

Originally posted by @serhii73 in #33 (comment)

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 25, 2019

Hey @serhii73 I'll take this issue

@serhii73
Copy link
Owner Author

@serhii73 serhii73 commented Oct 25, 2019

Thank you very much!

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 26, 2019

hey @serhii73... just started with the project... I want to integrate world_justice.csv into countries.csv I could see scraper module is written for this job... But what's the starting point of it? How to run it?

@serhii73
Copy link
Owner Author

@serhii73 serhii73 commented Oct 26, 2019

just started with the project... I want to integrate world_justice.csv into countries.csv

No. Please read https://github.com/place2live/place2live/blob/master/world_justice_project/world_justice.csv this file with python and add to ready data frame and show it to a user.
That's it.
Thank you very much!

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 28, 2019

this file with python and add to ready data frame and show it to a user.

@serhii73 is there any samples works already done... Please share the file URLs

@serhii73
Copy link
Owner Author

@serhii73 serhii73 commented Oct 28, 2019

this file with python and add to ready data frame and show it to a user.

@serhii73 is there any samples works already done... Please share the file URLs

Sorry?
Can you tell me more please what's failing?

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 28, 2019

I can't understand what's meant by ready data frame... Could you share some reference in code what do you meant by that?

@serhii73
Copy link
Owner Author

@serhii73 serhii73 commented Oct 28, 2019

Thank you very much for your question.
https://github.com/place2live/place2live/blob/master/where.py#L522 - print_out_df is ready data frame.
Does that make sense?

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 28, 2019

Thanks for clarifying... Yes, it does make sense but still, I've few doubts...

  • df is being initialized from countries.csv and justice data is not in that CSV. To import data from world_justice.csv into counties.csv I need to do this. But your reply says not to import data into coutries.csv
  • So I'm wondering is there any way to add data into print_out_df without even importing justice.csv into countries.csv. If so can you share me any reference work that has previously done, else clarify the way I need to proceed
@serhii73
Copy link
Owner Author

@serhii73 serhii73 commented Oct 28, 2019

https://github.com/place2live/place2live/blob/master/where.py#L520 - this is an example of how to add a new column to the data frame.

@dreamerchandra
Copy link

@dreamerchandra dreamerchandra commented Oct 28, 2019

thanks, I'll check

@stale
Copy link

@stale stale bot commented Aug 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 23, 2020
@serhii73 serhii73 closed this Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.