Modify os window check logic in test code#1627
Closed
khg0712 wants to merge 1 commit into
Closed
Conversation
youknowone
previously approved these changes
Dec 14, 2019
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Thanks for your contribution
khg0712
changed the title
khg0712
force-pushed
the
os_chk_is_win
branch
from
b870ea6 to
8c1718a
Compare
Member
|
I am sorry to not to finish this on time. but this is now outdated too much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current os check logic in test code can't distinguish window and unix.
I solve this problem and make code more clearly