append coverSlip to fullscreen element instead of body#4317
append coverSlip to fullscreen element instead of body#4317FlorianMaak wants to merge 2 commits intoplotly:masterfrom
Conversation
|
Thanks @FlorianMaak! But it looks to me as though the unprefixed |
|
Thanks very much for the PR @FlorianMaak - beyond browser support, it would be nice to write a test in the |
|
Sure. Going to migrate to fscreen and add tests as soon, as I'm at office tomorrow. |
|
Relating Tests: I think, we need to edit the karma config to work with fullscreen. Per default karma does not support fullscreen mode :/ |
Right, writing a "real" test for That said, if should be possible to test the new logic using jasmine spies. I'll be offline for the next two weeks, but @archmoj should be able to help you out if you run into problems. |
|
... and as for the failing tests. Merging master post #4321 should make them go green ✅ again. Sorry for the inconvenience |
|
@FlorianMaak could you please merge master into this branch and resolve the conflict? |
|
This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson |
Resolves #4259
This PR checks if there is a fullscreen element and appends dragelements coverSlip to this element instead of documents body.