Skip to content

bpo-39301: State that floor division is used for right shift operations#20347

Merged
mdickinson merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-39301-floor-division-bitshift-docs
May 26, 2020
Merged

bpo-39301: State that floor division is used for right shift operations#20347
mdickinson merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-39301-floor-division-bitshift-docs

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented May 24, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 24, 2020
mdickinson
mdickinson approved these changes May 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It may not completely resolve confusion, but it's a clear incremental improvement.

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented May 24, 2020

One thought: while we're here, could we remove the "without overflow check" part? I have no idea what it means, and I suspect no-one else does either. It may have made sense before long integers were the norm (though even then, I'm not sure what it means).

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented May 25, 2020

@ZackerySpytz Do you want to remove the "without overflow check" wording in this PR? If not, I'll merge this one and make a separate PR for changing that wording.

@rhettinger
Copy link
Copy Markdown
Contributor

rhettinger commented May 25, 2020

This looks good. Please do remove the "without overflow check" wording as well.

@mdickinson mdickinson merged commit af7553a into python:master May 26, 2020
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 26, 2020

Thanks @ZackerySpytz for the PR, and @mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2020
@ZackerySpytz @miss-islington
bpo-39301: State that floor division is used for right shift operatio…
cbdb1f0 
…ns (pythonGH-20347)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 26, 2020

GH-20414 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 26, 2020

GH-20415 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2020
@ZackerySpytz @miss-islington
bpo-39301: State that floor division is used for right shift operatio…
8f1f237 
…ns (pythonGH-20347)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2020
@ZackerySpytz @miss-islington
bpo-39301: State that floor division is used for right shift operatio…
140e9c7 
…ns (pythonGH-20347)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 26, 2020

GH-20416 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2020
@ZackerySpytz @miss-islington
bpo-39301: State that floor division is used for right shift operatio…
1ad2f90 
…ns (pythonGH-20347)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 26, 2020

GH-20417 is a backport of this pull request to the 3.6 branch.

@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented May 26, 2020

Ah, 3.6 is in security mode; I'll close that backport.

mdickinson pushed a commit that referenced this pull request May 26, 2020
@miss-islington @ZackerySpytz
bpo-39301: State that floor division is used for right shift operatio…
cc0f50d 
…ns (GH-20347) (GH-20414)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
mdickinson pushed a commit that referenced this pull request May 26, 2020
@miss-islington @ZackerySpytz
bpo-39301: State that floor division is used for right shift operatio…
c2a177a 
…ns (GH-20347) (GH-20415)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
mdickinson pushed a commit that referenced this pull request May 26, 2020
@miss-islington @ZackerySpytz
bpo-39301: State that floor division is used for right shift operatio…
b068d89 
…ns (GH-20347) (GH-20416)

* bpo-39301: State that floor division is used for right shift operations

* Remove "without overflow check"
(cherry picked from commit af7553a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

+1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @mdickinson @rhettinger @miss-islington @bedevere-bot @the-knights-who-say-ni