Skip to content

fix: fix ios hmr#8559

Merged
vtrifonov merged 1 commit into
NativeScript:masterfrom
kmmccafferty96:fix-ios-hmr
May 8, 2020
Merged

fix: fix ios hmr#8559
vtrifonov merged 1 commit into
NativeScript:masterfrom
kmmccafferty96:fix-ios-hmr

Conversation

@kmmccafferty96
Copy link
Copy Markdown
Contributor

@kmmccafferty96 kmmccafferty96 commented May 1, 2020

PR Checklist

What is the current behavior?

NativeScript/nativescript-cli#5293

What is the new behavior?

Fixes NativeScript/nativescript-cli#5293.

@kmmccafferty96
Copy link
Copy Markdown
Contributor Author

I don't think the code-modules-tests are failing due to my changes, but I can't reach http://nsbuild01.telerik.com to check.

@vtrifonov
Copy link
Copy Markdown
Contributor

sure, we'll check what the problem is!

@vtrifonov vtrifonov merged commit 446163d into NativeScript:master May 8, 2020
GulajavaMinistudio added a commit to TypescriptID/NativeScript that referenced this pull request May 22, 2020
Create a new pull request by comparing changes across two branchesfix: fix ios hmr (NativeScript#8559)
NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
NathanWalker pushed a commit that referenced this pull request Aug 7, 2020
tarunama pushed a commit to tarunama/NativeScript that referenced this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Material Bottom Navigation inside a lazy loaded module causes HMR to crash on iOS

2 participants