feat: setProperty on Observable#8521
Merged
Merged
Conversation
Member
Author
|
I'm a bit unsure if this will be usable in other frameworks I'm thinking of doing Would the |
tarunama
reviewed
Apr 12, 2020
tarunama
reviewed
Apr 12, 2020
tarunama
reviewed
Apr 12, 2020
tarunama
reviewed
Apr 12, 2020
vtrifonov
suggested changes
Apr 13, 2020
Co-Authored-By: Vasil Trifonov <v.trifonov@gmail.com>
vtrifonov
approved these changes
Apr 14, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* feat: setProperty on Observable * refactor: add missing whitespace Co-Authored-By: Vasil Trifonov <v.trifonov@gmail.com> Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
* feat: setProperty on Observable * refactor: add missing whitespace Co-Authored-By: Vasil Trifonov <v.trifonov@gmail.com> Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now when unknown properties are added/set on a View, css attribute selectors do not update the styling.
What is the new behavior?
A new
setPropertymethod has been added to Observable that will fire apropertyChangeand a${propertyName}Changeevent - which will get picked up by the css runtime and styles will update.The reason I've opted for a new method is because the
setmethod of the Observable is overwritten in Views - adding a new method allows triggering the correct events.Ref: #6122, #7914