Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRegisters no longer show changes #664
Comments
|
I confirmed the bug. I think it should be fairly easy to fix this. Would you like to work on that? I am on vacation so I might not have time to jump on it :P. |
|
I understand no problem. I’ve tried however I’m honestly still a beginner . I’m learning though I’ll see if I can try again when I understand more |
|
Oh shit I fixed it, it was a lot simpler than I expected. Once I read the guides I'll submit it |
|
@disconnect3d issue is still actual. Can i work on it? |
|
@piotrzarycki yup |
|
ok, so starting :) |
|
It's been a few months without any update here, so I made this change. If this isn't welcome, feel free to disregard my pull request |
|
I've pushed a fix. Is there any change to be made or can it be merged? |
|
@layderv Merged. Thanks! |
Description
In pwndbg release 2017.02.01 build: 1ab3de0, when registers changed while debugging a program, there would be an asterisk near the changed register which could be customized with context-register-changed-marker and context-register-changed-color.
These config options are still available, however in later releases (both 2018.07.29 and 2019.01.25) there doesn't seem to be anything next to changed registers anymore. The space is still there, which is more noticeable by changing the changed-marker to something longer, but it won't become visible.
It is still possible to see the asterisk, however only when changing a register manually, for example with set $eip=$eax. In this case an asterisk would appear near EIP for one instruction.
Steps to reproduce
I've tried this on Debian as well as blackarch, and it seems to be reproducible with any 32 or 64bit binary, at least on x86.
I believe stepping through any code where registers are being changed will reproduce it.
My setup
Debian:
Gdb: 8.2.1
Python: 3.7.3 (default, Apr 3 2019, 05:39:12) [GCC 8.3.0]
Pwndbg: 1.1.0 build: 88723a8
Capstone: 4.0.1024
Unicorn: 1.0.1
Blackarch:
Gdb: 8.3
Python: 3.7.3 (default, June 24 2019, 04:54:02) [GCC 9.1.0]
Pwndbg: 1.1.0
Capstone: 4.0.1024
Unicorn: 1.0.1