Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWrite up best practise to ensure encapsulation #6658
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fallout from architectural discussion:
Leaking Internals:
In addition to the very flat package structure, many of our classes leak their internals. We have many places where instances return their private copy of a mutable container. Lots of fields are public, mutable, and changed by external code. If this ever bites us, it will be hours in the debugger to find and fix.
GBM will write best practice in Wiki. Keep in mind for new PR/refactors.