Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write up best practise to ensure encapsulation #6658

Open
RealmBot opened this issue Nov 11, 2019 · 0 comments
Open

Write up best practise to ensure encapsulation #6658

RealmBot opened this issue Nov 11, 2019 · 0 comments
Labels

Comments

@RealmBot
Copy link

@RealmBot RealmBot commented Nov 11, 2019

Fallout from architectural discussion:

Leaking Internals:
In addition to the very flat package structure, many of our classes leak their internals. We have many places where instances return their private copy of a mutable container. Lots of fields are public, mutable, and changed by external code. If this ever bites us, it will be hours in the debugger to find and fix.

GBM will write best practice in Wiki. Keep in mind for new PR/refactors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.