Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open files containing curly braces #2510

Closed
michael-hawker opened this issue May 5, 2020 · 1 comment
Closed

Can't open files containing curly braces #2510

michael-hawker opened this issue May 5, 2020 · 1 comment

Comments

@michael-hawker
Copy link

@michael-hawker michael-hawker commented May 5, 2020

Versions

  • GitHub Extension for Visual Studio version: 2.11.96.24460
  • Visual Studio version: 16.5.4

What happened

Trying to open files from the GitHub PR explorer for this PR. It contains files with curly braces {} which won't open in VS. Getting a Error opening file: Input string was not in a correct format. error.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open PR in GitHub extension.
  2. Try to open any of the generic classes like ArrayPoolBufferWriter{T}.cs
  3. See error in status bar
  4. Note, if you pick another file (like the first one AllocationMode.cs it works fine, just fails on any file with curly brace).

Expected behavior

File opens.

Screenshots

image

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented May 7, 2020

Hi @michael-hawker 👋

@davidwengier has kindly contributed a fix for this!

Could you try installing the artifact from this build and let us know if it works?
https://github.com/github/VisualStudio/pull/2512/checks?check_run_id=653837445

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.