Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Open from GitHub" experience is misleading for Enterprises on GitHub.com #2459

Open
alwell-kevin opened this issue Feb 7, 2020 · 2 comments
Open

"Open from GitHub" experience is misleading for Enterprises on GitHub.com #2459

alwell-kevin opened this issue Feb 7, 2020 · 2 comments
Assignees
@jcansdale

Comments

@alwell-kevin
Copy link

@alwell-kevin alwell-kevin commented Feb 7, 2020

Versions

  • GitHub Extension for Visual Studio version: 2.10.8.8132
  • Visual Studio version: 2019, 16.4.3

What happened

After SSO into my GitHub Organization (on GitHub.com) I attempt to clone a repository. During that clone, the "Open from GitHub" dialog prompt appears (illustrated in the image below). The text "Resource protected by organization SAML enforcement. You must grant your personal token access to this organization" is misleading developers into thinking they need to re-authenticate in some way while they actually have a valid session and can successfully access Org resources.

Screen Shot 2020-02-07 at 4 05 23 PM

Steps to Reproduce

Steps to reproduce the behavior:

  1. Login with Browser to SSO enable extension
  2. Dialog prompt appears, observe misleading text.

Expected behavior

  1. Login with Browser to SSO enable extension
  2. Some indication that I have a valid session and can access SAML protected resources.

Screenshots

Screen Shot 2020-02-07 at 4 05 23 PM

Additional context

cc: @Johnjay0, @rchillara07, @mienabeard
@mkarliner
Copy link

@mkarliner mkarliner commented Feb 15, 2020

Also, this file VisualStudio/docs/getting-started/authenticating-to-github.md

does not mention installing the extension, and nowhere does it say I have to close VS first.
@jcansdale jcansdale self-assigned this Feb 24, 2020
@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Feb 28, 2020

Hi folks 👋

From the clone dialog, could you click on Add/Change Accounts. Then select the GitHub tab and Sign in with your browser. You should then have to option to authenticate for your SAML SSO protected organization!

image

Singing in using a username/password is being deprecated in favor of the web-flow. I'm hoping to remove the username/password option entirely to avoid this potential confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcansdale jcansdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@mkarliner @jcansdale @alwell-kevin
You can’t perform that action at this time.