Skip to content

/ mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate mysql.NullTime #960

Open
julienschmidt opened this issue Apr 30, 2019 · 2 comments
Open

Deprecate mysql.NullTime #960

julienschmidt opened this issue Apr 30, 2019 · 2 comments
Labels
Go1.13 documentation
Milestone
v1.7.0

Comments

@julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Apr 30, 2019

database/sql will have a NullTime type from Go1.13 onward, which should be used instead: golang/go#30305
@julienschmidt julienschmidt added this to the v1.6.0 milestone Apr 30, 2019
@dolmen
Copy link
Contributor

@dolmen dolmen commented Sep 4, 2019

Or better: make mysql.NullTime an alias to database/sql.NullTime when compiling on Go 1.13+.

I will submit a PR to implement this solution.
@dolmen dolmen mentioned this issue Sep 4, 2019
Open
@dolmen
Copy link
Contributor

@dolmen dolmen commented Sep 4, 2019

Well, the Scan method is specific to MySQL, so we have to keep it. I will change to wrap database/sql.NullTime.
@dolmen dolmen mentioned this issue Sep 4, 2019
Merged
3 of 5 tasks complete
@smtakeda smtakeda mentioned this issue Nov 16, 2019
Open
@shogo82148 shogo82148 mentioned this issue Jan 5, 2020
Closed
0 of 5 tasks complete
@methane methane mentioned this issue May 26, 2020
Merged
5 of 5 tasks complete
@julienschmidt julienschmidt modified the milestones: v1.6.0, v1.7.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Go1.13 documentation
Projects
None yet
Milestone
  v1.7.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@dolmen @julienschmidt
You can’t perform that action at this time.